[libcxx-commits] [PATCH] D99697: [CMake] Remove {LIBCXX, LIBCXXABI, LIBUNWIND}_INSTALL_PREFIX

John Ericson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 31 21:44:44 PDT 2021


Ericson2314 added a comment.

Oh there is a stray `LIBCXX_INSTALL_HEADER_PREFIX` in `LIBCXX_INSTALL_HEADER_PREFIX` that should be removed, FYI.

Also, If someone does want the extra knobs after all, making a `LIBCXX_INSTALL_HEADER_DIR`/`LIBCXX_INSTALL_INCLUDEDIR` (same idea, two different possible names) matching `LIBCXX_INSTALL_LIBRARY_DIR` would also fit in with `GNUInstallIdirs` more nicely, I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99697/new/

https://reviews.llvm.org/D99697



More information about the libcxx-commits mailing list