[libcxx-commits] [PATCH] D97802: [libc++] Fix incorrect typeinfo comparison on ARM64
John McCall via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Mar 31 15:06:58 PDT 2021
rjmccall added inline comments.
Comment at: libcxx/include/typeinfo:151
+// the RTTI for a given type inside a program. When constructing the type_info,
+// the compilers packs the pointer to the type name into a uintptr_t and reserves
+// the high bit of that pointer, which is assumed to be free for use under that
Comment at: libcxx/include/typeinfo:162
+// the other one isn't, then both RTTIs are necessarily not to be considered
This is not correct. We should only perform a string comparison if *both* RTTIs are non-unique. I still don't think this is a runtime bug.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits