[libcxx-commits] [PATCH] D97802: [libc++] Fix incorrect typeinfo comparison on ARM64

[John McCall via Phabricator via libcxx-commits]

rjmccall added inline comments.


================
Comment at: libcxx/include/typeinfo:151
+// the RTTI for a given type inside a program. When constructing the type_info,
+// the compilers packs the pointer to the type name into a uintptr_t and reserves
+// the high bit of that pointer, which is assumed to be free for use under that
----------------
"compiler"


================
Comment at: libcxx/include/typeinfo:162
+// the other one isn't, then both RTTIs are necessarily not to be considered
+// equal.
 //
----------------
This is not correct.  We should only perform a string comparison if *both* RTTIs are non-unique.  I still don't think this is a runtime bug.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97802/new/

https://reviews.llvm.org/D97802