[libcxx-commits] [PATCH] D99178: [libcxx] Disable c++experimental by default in DLL builds
Martin Storsjö via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Mar 31 12:28:59 PDT 2021
mstorsjo added inline comments.
Comment at: libcxx/docs/BuildingLibcxx.rst:93
- -DLIBCXX_ENABLE_EXPERIMENTAL_LIBRARY=NO ^
> I assume things go wrong if the user uses `-DLIBCXX_ENABLE_EXPERIMENTAL_LIBRARY=YES`. Can you document this isn't supported? I think it would be nice if CMake doesn't allow this invalid combination.
I kind of wanted to leave it possible to do that still, while you'd essentially be on your own in that case. But I guess I could at least add a cmake warning for that combination - or a hard error if others also feel that way.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits