[libcxx-commits] [PATCH] D99373: [SystemZ][z/OS] tune down warning about unused parameter on nanosleep()

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

Some minor issues, other than that LGTM.



================
Comment at: libcxx/include/__support/ibm/nanosleep.h:41
+  if (__micro_sec) {
+    int rc = usleep(__micro_sec);
+    if (rc != 0 && __rem) {
----------------
`rc` -> `__rc`.


================
Comment at: libcxx/include/__support/ibm/nanosleep.h:44
+      __rem->tv_sec = 0;
+      __rem->tv_nsec = __micro_sec * 1000;
+      // errno is already set
----------------
Should we add a comment this value might be too large?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99373/new/

https://reviews.llvm.org/D99373