[libcxx-commits] [PATCH] D96385: [libc++] [P1032] Finish constexpr-ifying <iterator>, <string_view>, <tuple>, <utility>.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D96385#2661434 <https://reviews.llvm.org/D96385#2661434>, @Quuxplusone wrote:

> Okay @ldionne @uabelho @vvereschaka, I've pushed 3bdd674fbf767d719dc67e10bc079cb183dd3a3f <https://reviews.llvm.org/rG3bdd674fbf767d719dc67e10bc079cb183dd3a3f> to hopefully green the buildbots again.
>
> For the record, the specific culprit here is
> https://bugs.llvm.org/show_bug.cgi?id=45879
>
> But running creduce on the failing test, with different random seeds, also produced instances of
> https://bugs.llvm.org/show_bug.cgi?id=21826
> https://bugs.llvm.org/show_bug.cgi?id=49734
> https://bugs.llvm.org/show_bug.cgi?id=49735
> https://bugs.llvm.org/show_bug.cgi?id=49749
> https://bugs.llvm.org/show_bug.cgi?id=49759

Thanks for your investigations Arthur, and sorry for missing your previous @ on March 26th.

I think marking the test as unsupported is fine as a temporary solution to keep the bots green, which is the #1 priority.

However, this is going to start failing again next release, and so on, until we fix the underlying bug, so I think we should either work on a libc++ workaround to stop triggering the bug, or on fixing the actual Clang issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96385/new/

https://reviews.llvm.org/D96385