[libcxx-commits] [PATCH] D99175: [libcxx] [test] Make the condvar wait_for tests less brittle

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 31 07:46:00 PDT 2021


mstorsjo added inline comments.


================
Comment at: libcxx/test/std/thread/thread.condition/thread.condition.condvar/wait_for.pass.cpp:54
     Clock::time_point t1 = Clock::now();
     if (runs == 0)
     {
----------------
Quuxplusone wrote:
> FWIW, I still think it'd be nice to rename `runs == 0` to `!expect_timeout`.
Sure, I can make a separate change for that after landing this (after a second review).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99175/new/

https://reviews.llvm.org/D99175



More information about the libcxx-commits mailing list