[libcxx-commits] [PATCH] D99096: [libcxx] [test] Fix tests of <cuchar> that unexpectedly succeed on windows

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo updated this revision to Diff 334253.
mstorsjo added a comment.

... now also amended with the requested comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99096/new/

https://reviews.llvm.org/D99096

Files:
  libcxx/test/libcxx/strings/c.strings/version_cuchar.pass.cpp
  libcxx/test/std/strings/c.strings/cuchar.pass.cpp


Index: libcxx/test/std/strings/c.strings/cuchar.pass.cpp
===================================================================
--- libcxx/test/std/strings/c.strings/cuchar.pass.cpp
+++ libcxx/test/std/strings/c.strings/cuchar.pass.cpp
@@ -8,6 +8,11 @@
 //
 // XFAIL: libc++
 
+// Skip this test on windows. If built on top of the MSVC runtime, the
+// <cuchar> header actually does exist (although not provided by us).
+// This should be removed once D97870 has landed.
+// UNSUPPORTED: windows
+
 // <cuchar>
 
 #include <cuchar>
Index: libcxx/test/libcxx/strings/c.strings/version_cuchar.pass.cpp
===================================================================
--- libcxx/test/libcxx/strings/c.strings/version_cuchar.pass.cpp
+++ libcxx/test/libcxx/strings/c.strings/version_cuchar.pass.cpp
@@ -8,6 +8,11 @@
 //
 // XFAIL: *
 
+// Skip this test on windows. If built on top of the MSVC runtime, the
+// <cuchar> header actually does exist (although not provided by us).
+// This should be removed once D97870 has landed.
+// UNSUPPORTED: windows
+
 // <cuchar>
 
 #include <cuchar>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99096.334253.patch
Type: text/x-patch
Size: 1086 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210330/143e25b0/attachment.bin>