[libcxx-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

[John Ericson via Phabricator via libcxx-commits]

Ericson2314 added a comment.

@lebedev.ri Those are intentional. I changed `POLLY_INSTALL_PREFIX` and `COMPILER_RT_INSTALL_PATH` to be `""` instead of `${CMAKE_INSTALL_PREFIX}` by default. If if kept it more as it was, the GNU dir outside the prefix (as I needed to do) wouldn't work. I suppose I could instead use https://cmake.org/cmake/help/v3.16/command/get_filename_component.html to keep those prefix ones as is? But I would still need to use the `_FULL` variables in the calculation.

There is https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html#command:gnuinstalldirs_get_absolute_install_dir which would be nice to use for this, except there is no parameter to make it expand relative something other than `CMAKE_INSTALL_PREFIX`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99484/new/

https://reviews.llvm.org/D99484