[libcxx-commits] [PATCH] D99515: [libc++] Build and test with -Wundef warning. NFC.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/__config:513-514
 // Literal operators ""d and ""y are supported starting with LLVM Clang 8 and AppleClang 10.0.1
-#if (defined(_LIBCPP_CLANG_VER) && _LIBCPP_CLANG_VER < 800) || \
+#if (defined(_LIBCPP_CLANG_VER) && _LIBCPP_CLANG_VER != 0 &&                   \
+     _LIBCPP_CLANG_VER < 800) ||                                               \
     (defined(__apple_build_version__) && __apple_build_version__ < 10010000)
----------------
curdeius wrote:
> I know, that's ugly...
> Should I use `__clang__` / `__clang_major` directly (not sure how it's defined on AppleClang though?
> 
> Or, is mapping AppleClang version to clang version somehow possible, @ldionne?
> Or, is mapping AppleClang version to clang version somehow possible, @ldionne?

Not really. Since we fork at roughly arbitrary points in time, we would often fall between two official Clang releases and the mapping wouldn't be accurate.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99515/new/

https://reviews.llvm.org/D99515