[libcxx-commits] [PATCH] D99241: [libcxx] [test] Don't add dirs from the LIB env var to PATH

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 29 22:35:30 PDT 2021

mstorsjo added a comment.

In D99241#2656852 <https://reviews.llvm.org/D99241#2656852>, @amccarth wrote:

> Adding everything in LIB to PATH is not a normal thing to do in Windows, so I would support this patch to remove that hack.  If we knew what the original problem was, we could probably find a better solution.
> When you run the tests, does anything differ with and without this patch?

Nothing differs when it comes to actually executing/passing tests. The only visible difference is that the executor scripts are passed fewer paths via the `--env` option.

So my guess is that it was an attempt at fixing something, done at the same time as a number of other changes, without verifying that this particular change actually had any effect.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list