[libcxx-commits] [PATCH] D97888: [libc++] Add a CI job to test the Runtimes build

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/utils/ci/run-buildbot:362
+          -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \
+          -DLLVM_RUNTIME_TARGETS="x86_64-unknown-linux"
+
----------------
phosek wrote:
> phosek wrote:
> > I'd use a full canonical target.
> Turns out this is actually the reason for some of the failing tests. There are some directives in tests that check for `linux-gnu` but if you use just `x86_64-unknown-linux` those aren't matched.
Oh, how sloppy of me. I thought I had done it. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97888/new/

https://reviews.llvm.org/D97888