[libcxx-commits] [PATCH] D99515: [libc++] Build and test with -Wundef warning. NFC.

Marek Kurdej via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 29 12:32:01 PDT 2021


curdeius added a comment.

@Quuxplusone, this change broke mac build (it defines `_LIBCPP_COMPILER_CLANG` but doesn't define `_LIBCPP_CLANG_VER`) and to fix it I've uglified what you did in D98720 <https://reviews.llvm.org/D98720>.
If you have a better idea, I'm all ears.

BTW, this change finds less real bugs *now* than it could, because I've fixed some tests that used `TEST_STD_VER` but were missing includes of "test_macros.h" a week or two ago.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99515/new/

https://reviews.llvm.org/D99515



More information about the libcxx-commits mailing list