[libcxx-commits] [PATCH] D99515: [libc++] Build and test with -Wundef warning. NFC.

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added inline comments.


================
Comment at: libcxx/CMakeLists.txt:580
   else()
-    target_add_compile_flags_if_supported(${target} PRIVATE -Wall)
+    target_add_compile_flags_if_supported(${target} PRIVATE -Wall -Wundef)
   endif()
----------------
Maybe that's not the best place to put this flag... Should I put it twice for clang (line 586+), and gcc (line 611+)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99515/new/

https://reviews.llvm.org/D99515