[libcxx-commits] [PATCH] D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added inline comments.


================
Comment at: libcxx/test/std/utilities/utility/intcmp/intcmp.fail.cpp:115
   test<long double>();
   test<std::byte>();
 #ifndef _LIBCPP_NO_HAS_CHAR8_T
----------------
Please test some non-primitive non-enum type.


================
Comment at: libcxx/test/std/utilities/utility/utility.intcmp/intcmp.cmp_greater/cmp_greater.pass.cpp:102
+      uint32_t, int32_t, unsigned int, int, uint16_t, int16_t, unsigned short,
+      short, uint8_t, int8_t>;
+  assert(test1(Types1{}) && test2(Types1{}, Types1{}) &&
----------------
Please test `signed char` and `unsigned char`. This applies to other tests too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94511/new/

https://reviews.llvm.org/D94511