[libcxx-commits] [PATCH] D98151: [libcxx] adds std::identity to <functional>

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Mar 27 15:06:22 PDT 2021


cjdb marked an inline comment as done.
cjdb added inline comments.


================
Comment at: libcxx/test/std/utilities/function.objects/func.identity/identity.pass.cpp:111
+
+  [[noexcept]] constexpr bool operator==(S2 const&) const noexcept = default;
+};
----------------
EricWF wrote:
> Do we the defaulted comparison operator here? I would rather not depend on yet another new language feature that we don't need too.
I think per @Quuxplusone's changes, this comment is outdated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98151/new/

https://reviews.llvm.org/D98151



More information about the libcxx-commits mailing list