[libcxx-commits] [PATCH] D99141: [libcxx] adds `std::incrementable_traits` to <iterator>
Christopher Di Bella via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Mar 26 10:03:09 PDT 2021
cjdb added a comment.
In D99141#2648240 <https://reviews.llvm.org/D99141#2648240>, @Mordante wrote:
> Can you also make sure the patch passes CI?
This is failing CI because of a bug in GCC 10 that was fixed in trunk (example <https://godbolt.org/z/9W1GEYaKo>). @ldionne should I add an include guard around the offending line or should we upgrade our CI's GCC?
Comment at: libcxx/include/iterator:16
> Can you add the required includes?
> #include <compare> // see [compare.syn]
> #include <concepts> // see [concepts.syn]
I've added it for `<concepts>`, but will leave `<compare>` for the person who adds that functionality (probably me in a future patch).
Comment at: libcxx/include/iterator:427
> Maybe also add compare while you're at it.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits