[libcxx-commits] [PATCH] D99398: [libcxx] reworks invocable and regular_invocable tests

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

Well, it hinges on what you mean by

> and does not introduce new duplication

>From my POV, obviously this patch introduces MASSIVE duplication. Lines 1-500 are very similar to lines 501-1000. That's literally all. I don't think we should have 1000 lines of highly repetitive tests, just to test a three-line metafunction. It makes it harder for the maintainer to see what's actually tested and what's not.

(Minorly, I think line 258 doesn't match the style we've been using for other constexpr tests. These constexpr functions could all be using `assert` in the bodies and `return true` at the end.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99398/new/

https://reviews.llvm.org/D99398