[libcxx-commits] [PATCH] D99398: [libcxx] reworks invocable and regular_invocable tests

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 26 06:34:48 PDT 2021


ldionne added a comment.

In D99398#2652342 <https://reviews.llvm.org/D99398#2652342>, @Quuxplusone wrote:

> Personally, I don't think these 1000 new lines of code provide enough benefit to offset their cost. The lines-to-useful-tests ratio is very low.

Can you elaborate?

There seems to have been a fixation on line counts lately. If it increases test coverage and does not introduce new duplication, then this change is beneficial.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99398/new/

https://reviews.llvm.org/D99398



More information about the libcxx-commits mailing list