[libcxx-commits] [PATCH] D99263: [libcxx] [test] Link against msvcprt in tests
Marek Kurdej via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Mar 26 04:22:42 PDT 2021
curdeius accepted this revision as: curdeius.
curdeius added a comment.
At the first sight, I thought that the whole story of linking another C++ standard library to build/test another was strange, but finally, that makes sense (for the ABI), and it's not MSVC specific.
Comment at: libcxx/utils/libcxx/test/config.py:449
cxx_abi = self.get_lit_conf('cxx_abi', 'libcxxabi')
Could you add a comment (somewhere) mentioning the corresponding flags in CMakeLists.txt, please?
They should probably be always in sync.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits