[libcxx-commits] [PATCH] D97572: [libc++] Include <__config_site> from <__config>

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 25 11:49:43 PDT 2021


ldionne added a comment.

In D97572#2648233 <https://reviews.llvm.org/D97572#2648233>, @phosek wrote:

> Looks like presubmit checks are passing now.

I'm pretty sure we'll need the `cxx-headers` change in libcxxabi (D98367 <https://reviews.llvm.org/D98367>) to make this change, no? Otherwise, we might break some people building and testing libc++abi in funky ways. I'd also wait until https://reviews.llvm.org/D97888 has landed so that the pre-commit tests include the Runtimes build. But except for that, I think this is good and I'm excited/scared to try this again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97572/new/

https://reviews.llvm.org/D97572



More information about the libcxx-commits mailing list