[libcxx-commits] [PATCH] D99307: [libc++] Eliminate <compare>'s dependency on <array>

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 25 07:30:32 PDT 2021

Quuxplusone added a comment.

@grandinj wrote:

> Perhaps the output of this should be generated by the build, and committed to git, so it becomes obvious in a given commit when it changes drastically?

Well, we do have a bunch of things that are generated by scripts and it'd be nice to make that happen automatically. However, the thing about this graph is that the cumulative line counts would change //with every line added or removed//, which means it would be changing all the time and making ugly extra git diffs. (Or we could check in only the graph-without-line-counts, but the graph-without-line-counts is significantly less interesting/useful/satisfying IMO.)
(And this is leaving aside the separate question of how we'd "check in the graph" anyway. git isn't great with binary files. We could check in the .dot file and let people render the graph into an image locally.)

I am planning to PR a family of tests for discrete propositions — such as "`<compare>` does //not// pull in `std::array`" or "`<algorithm>` does //not// pull in `std::type_info`" or "`<memory>` does //not// pull in `std::ostream`" — which I think will be better at the goal of making sure improvements like this are not regressed accidentally in the future.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list