[libcxx-commits] [PATCH] D90615: [libunwind] Add missing #include <alloca.h>

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libunwind/src/config.h:128
+#include <alloca.h>
 #define _LIBUNWIND_REMEMBER_ALLOC(_size) alloca(_size)
 #define _LIBUNWIND_REMEMBER_FREE(_ptr)                                         \
----------------
arichardson wrote:
> Couldn't this simply be changed to `__builtin_alloca()` to avoid the header dependency?
Within suitable `ifdef __GNUC__` (possibly with some `__has_builtin()`), then maybe I guess that could be doable


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90615/new/

https://reviews.llvm.org/D90615