[libcxx-commits] [PATCH] D99309: [libc++] Header inclusion tests

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added inline comments.


================
Comment at: libcxx/utils/generate_header_inclusion_tests.py:20
+
+mandatory_inclusions = {
+    "algorithm": ["initializer_list"],
----------------
A small comment on how to get/update this list would be nice (grepping draft's source TeX for `#include` and so on).


================
Comment at: libcxx/utils/generate_header_inclusion_tests.py:179
+int main(int, char**) {{ return 0; }}
+""".strip()
+
----------------
Nit: new line.


================
Comment at: libcxx/utils/generate_header_inclusion_tests.py:192
+        )
+        test_name = "{header}.inclusions.pass.cpp".format(header=includer)
+        out_path = os.path.join(test_path, test_name)
----------------
Depending on what we decide on .pass vs. .compile.pass, these tests are candidates for begin compile.pass tests (with a defensive `return 1;` in main).
And, as they're generated, there's less risk to make things incorrect (mind that I don't say "no risk" because someone might theoretically add runtime tests in this generator script).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99309/new/

https://reviews.llvm.org/D99309