[libcxx-commits] [PATCH] D99307: [libc++] Eliminate <compare>'s dependency on <array>

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 24 22:03:57 PDT 2021


zoecarver accepted this revision as: zoecarver.
zoecarver added a comment.

This LGTM once the CI is fixed. Thanks!



================
Comment at: libcxx/include/compare:703
 constexpr _ClassifyCompCategory
-__compute_comp_type(array<_ClassifyCompCategory, _Size> __types) {
-  array<int, _CCC_Size> __seen = {};
+__compute_comp_type(_ClassifyCompCategory (&__types)[_Size]) {
+  int __seen[_CCC_Size] = {};
----------------
Looks like the CI wants this to be const. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99307/new/

https://reviews.llvm.org/D99307



More information about the libcxx-commits mailing list