[libcxx-commits] [PATCH] D99309: [libc++] Header inclusion tests

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb requested changes to this revision.
cjdb added a comment.
This revision now requires changes to proceed.

Overall LGTM.



================
Comment at: libcxx/include/chrono:16
 
+#include <compare>
+
----------------
Have we added `<compare>` support for `<chrono>` yet? If not, I'd prefer to keep it out of the synopsis. (If you're keeping it in, please add `// C++20` or something.)


================
Comment at: libcxx/test/libcxx/inclusions/algorithm.inclusions.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
Can these please be placed under `libcxx/test/std/.../${subclause}/${subclause}.syn/` instead? They're responsible for checking the synopsis, so I'd prefer they sit with the other tests of their category.


================
Comment at: libcxx/test/libcxx/inclusions/algorithm.inclusions.pass.cpp:29
+int main(int, char**) { return 0; }
\ No newline at end of file

----------------
Missing new line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99309/new/

https://reviews.llvm.org/D99309