[libcxx-commits] [PATCH] D99095: [libcxx] [test] Add XFAIL LIBCXX-WINDOWS-FIXME in 124 tests that fail in the CI configuration

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 24 11:51:33 PDT 2021


Mordante added a comment.

I'm not sure how temporary this solution is, but there's an issue with the feature-test macro script after this commit. IMO if it's very temporary we don't need to take action otherwise I think we should look at a fix.



================
Comment at: libcxx/test/std/language.support/support.limits/support.limits.general/complex.version.pass.cpp:16
 
+// XFAIL: LIBCXX-WINDOWS-FIXME
+
----------------
This file and the other `*.version.pass.cpp` are automatically generated by `utils/generate_feature_test_macro_components.py`. If a developer runs this script these changes will accidentally be reverted. I'm not sure what would be the best fix for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99095/new/

https://reviews.llvm.org/D99095



More information about the libcxx-commits mailing list