[libcxx-commits] [PATCH] D97913: [runtimes] Use add_lit_testsuite to register lit testsuites
David Zarzycki via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Mar 24 08:07:26 PDT 2021
davezarzycki added a comment.
In D97913#2647721 <https://reviews.llvm.org/D97913#2647721>, @ldionne wrote:
> In D97913#2637023 <https://reviews.llvm.org/D97913#2637023>, @davezarzycki wrote:
>> In D97913#2635064 <https://reviews.llvm.org/D97913#2635064>, @ldionne wrote:
>>> Why do you use these settings?
>>> What is the intent of your build job?
>> I try to ensure that building/testing works with PIC disabled, which (of course) requires disabling shared libraries.
> @davezarzycki The problem here is that this change enabled the libc++ and libc++abi tests in your job, which were not being run before. I think there might be issues with the configuration you're using and this change only makes those issues apparent.
Can you please elaborate on what those issues might be?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits