[libcxx-commits] [PATCH] D99268: [libc++] Add a CI configuration with static libc++/libc++abi

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/utils/ci/run-buildbot:89-90
 function check-cxx-cxxabi() {
+    echo "--- Installing libc++ and libc++abi to a fake location"
+    ${NINJA} -vC "${BUILD_DIR}" install-cxx install-cxxabi
+
----------------
curdeius wrote:
> Does it change anything for other (non-static) test configurations?
> IIUC, without installing first, tests would find a possibly different instance of libc++.a (if there's one somewhere in link dirs) or find none, right?
> Was it the case with the dynamic lib?
I don't expect there should be any difference. This is only a cheap way to fix the issue that dependencies are not properly specified with the static library, i.e. `check-cxx` won't build the static library first when you run it. I looked into solving the underlying issue and it would complicate the CMake quite a bit in the current state of things, so I wanted to start by simplifying the CMake configuration (https://reviews.llvm.org/D97565 will enable that as a follow-up step).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99268/new/

https://reviews.llvm.org/D99268