[libcxx-commits] [PATCH] D97572: [libc++] Include <__config_site> from <__config>

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 23 18:01:27 PDT 2021


phosek marked an inline comment as done.
phosek added inline comments.


================
Comment at: libcxx/docs/TestingLibcxx.rst:44
+before running the tests manually with `lit` when you make any sort of change,
+including to the headers.
+
----------------
Quuxplusone wrote:
> Is running `[ninja|make] cxx` specifically //not// enough? (I'm guessing the answer is "yes, not enough.") That answer should be called out explicitly in the text.
This section specifically is about using llvm-lit directly, if you're using `ninja` or `make` you can just run `check-cxx`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97572/new/

https://reviews.llvm.org/D97572



More information about the libcxx-commits mailing list