[libcxx-commits] [PATCH] D96385: [libc++] [P1032] Finish constexpr-ifying <iterator>, <string_view>, <tuple>, <utility>.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/test/std/strings/string.view/string.view.ops/copy.pass.cpp:9-11
+// UNSUPPORTED: gcc-10
+//     GCC's __builtin_strlen isn't constexpr yet
+
----------------
Quuxplusone wrote:
> @ldionne, any thoughts on this bit?
I think this is reasonable. I think I'd rather wait for GCC to make their `__builtin_strlen` constexpr than add a GCC specific workaround for that in the library.

We could make it `XFAIL` so we're notified (by an XPASS) once GCC makes it `constexpr`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96385/new/

https://reviews.llvm.org/D96385