[libcxx-commits] [PATCH] D99241: [libcxx] [test] Don't add dirs from the LIB env var to PATH

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 24 00:47:12 PDT 2021

mstorsjo created this revision.
mstorsjo added a reviewer: EricWF.
Herald added a subscriber: arichardson.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

The directories in LIB normally only contain import libraries or
static libraries, no runtime DLLs that would need to be found
while running tests.

This code stems from 1cd196e7b46e49d170a4b4013879a577dee59cb2,
which (among other things) tried to do this:

> - [Test] Fix handling of library runtime search paths by correctly adding them to the PATH variable when running the tests.

It's unclear to me exactly what this fixed (or tried to) at the time,
as the LIB var doesn't normally point to runtime libs.

  rG LLVM Github Monorepo



Index: libcxx/utils/libcxx/test/config.py
--- libcxx/utils/libcxx/test/config.py
+++ libcxx/utils/libcxx/test/config.py
@@ -209,8 +209,6 @@
         flags = []
         compile_flags = []
         link_flags = _prefixed_env_list('LIB', '-L')
-        for path in _split_env_var('LIB'):
-            self.add_path(self.exec_env, path)
         return CXXCompiler(self, clang_path, flags=flags,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99241.332881.patch
Type: text/x-patch
Size: 569 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210324/81243df7/attachment.bin>

More information about the libcxx-commits mailing list