[libcxx-commits] [PATCH] D99213: [libcxx] Avoid pulling in xlocinfo.h in public headers

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 23 14:02:16 PDT 2021

mstorsjo added a comment.

In D99213#2645949 <https://reviews.llvm.org/D99213#2645949>, @curdeius wrote:

> LGTM. I've been looking at those failing tests that were indeed pulling in MS STL's <yvals_core.h> but I didn't go further.

Ooo, nice, that sound great if you're getting nerdsniped into looking into these ;-)

Comment at: libcxx/include/__support/win32/locale_win32.h:26
+#define _X_MESSAGES 6
+#define _NCAT 7
curdeius wrote:
> Why not doing the same as https://github.com/microsoft/STL/blob/main/stl/inc/xlocinfo.h#L35? I.e. `_X_MESSAGES + 1`.
> No strong feelings about it anyway.
Sure, I can do that too.

Technically, we don't need `_X_ALL` or `_M_ALL`at all, so we could just omit them too, but I thought it'd be best to provide the same full set as the corresponding MSVC headers do, for consistency.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list