[libcxx-commits] [PATCH] D99213: [libcxx] Avoid pulling in xlocinfo.h in public headers
Marek Kurdej via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Mar 23 13:51:29 PDT 2021
curdeius accepted this revision as: curdeius.
curdeius added a comment.
LGTM. I've been looking at those failing tests that were indeed pulling in MS STL's <yvals_core.h> but I didn't go further.
Comment at: libcxx/include/__support/win32/locale_win32.h:26
+#define _X_MESSAGES 6
+#define _NCAT 7
Why not doing the same as https://github.com/microsoft/STL/blob/main/stl/inc/xlocinfo.h#L35? I.e. `_X_MESSAGES + 1`.
No strong feelings about it anyway.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits