[libcxx-commits] [libcxx] 247f8f6 - [libcxx] [test] Remove a couple outdated XFAIL LIBCXX-WINDOWS-FIXME

Martin Storsjö via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 22 14:41:21 PDT 2021


Author: Martin Storsjö
Date: 2021-03-22T23:41:10+02:00
New Revision: 247f8f6719bce8162e71e53770a338f98267c8e3

URL: https://github.com/llvm/llvm-project/commit/247f8f6719bce8162e71e53770a338f98267c8e3
DIFF: https://github.com/llvm/llvm-project/commit/247f8f6719bce8162e71e53770a338f98267c8e3.diff

LOG: [libcxx] [test] Remove a couple outdated XFAIL LIBCXX-WINDOWS-FIXME

With current versions of MSVC, these tests do succeed.

Differential Revision: https://reviews.llvm.org/D99094

Added: 
    

Modified: 
    libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow_replace.pass.cpp
    libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow_replace.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow_replace.pass.cpp b/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow_replace.pass.cpp
index e7a1e403d73d..8f87dfc5f815 100644
--- a/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow_replace.pass.cpp
+++ b/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow_replace.pass.cpp
@@ -20,11 +20,6 @@
 // XFAIL: with_system_cxx_lib=macosx10.10
 // XFAIL: with_system_cxx_lib=macosx10.9
 
-// On Windows libc++ doesn't provide its own definitions for new/delete
-// but instead depends on the ones in VCRuntime. However VCRuntime does not
-// yet provide aligned new/delete definitions so this test fails.
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 // test operator new nothrow by replacing only operator new
 
 #include <new>

diff  --git a/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow_replace.pass.cpp b/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow_replace.pass.cpp
index 62ceafb7644a..efbb8fce9670 100644
--- a/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow_replace.pass.cpp
+++ b/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow_replace.pass.cpp
@@ -20,11 +20,6 @@
 // XFAIL: with_system_cxx_lib=macosx10.10
 // XFAIL: with_system_cxx_lib=macosx10.9
 
-// On Windows libc++ doesn't provide its own definitions for new/delete
-// but instead depends on the ones in VCRuntime. However VCRuntime does not
-// yet provide aligned new/delete definitions so this test fails.
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 // test operator new nothrow by replacing only operator new
 
 #include <new>


        


More information about the libcxx-commits mailing list