[libcxx-commits] [PATCH] D99093: [libcxx] [ci] Add a Windows CI buildkite configuration
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Mar 22 12:15:06 PDT 2021
ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.
This is great, thanks a lot for working on it!
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:282
+ # The CI runner doesn't have bash in the path currently
+ command: "\"\\Program Files\\Git\\usr\\bin\\bash\" libcxx/utils/ci/run-buildbot generic-win"
How far are we from fixing this?
Comment at: libcxx/utils/ci/run-buildbot:430-437
+ # -D_LIBCPP_HAS_NO_INT128 allows building filesystem with a MSVC
+ # setup that lacks the necessary builtins for int128.
+ # -loldnames is needed for some tests unless using Clang 12 (the
+ # CI runner has Clang 11 currently).
+ # -DLIBCXX_ENABLE_EXPERIMENTAL_LIBRARY=NO is needed, as the testsuite
Shouldn't we fix those issues instead of working around them? Since we're soft-failing the runner anyway, we could add the job without those work arounds and let it soft-fail until we've fixed all issues?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits