[libcxx-commits] [PATCH] D99096: [libcxx] [test] Fix tests of <cuchar> that unexpectedly succeed on windows

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

The tests expect that the <cuchar> include should fail. When libc++
is built on top of the MSVC runtime, the header does exist provided
by MSVC. Therefore, just mark the test as unsupported on windows,
to avoid tests that unexpectedly succeed.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99096

Files:
  libcxx/test/libcxx/strings/c.strings/version_cuchar.pass.cpp
  libcxx/test/std/strings/c.strings/cuchar.pass.cpp


Index: libcxx/test/std/strings/c.strings/cuchar.pass.cpp
===================================================================
--- libcxx/test/std/strings/c.strings/cuchar.pass.cpp
+++ libcxx/test/std/strings/c.strings/cuchar.pass.cpp
@@ -8,6 +8,10 @@
 //
 // XFAIL: libc++
 
+// Skip this test on windows. If built on top of the MSVC runtime, the
+// <cuchar> header actually does exist (although not provided by us).
+// UNSUPPORTED: windows
+
 // <cuchar>
 
 #include <cuchar>
Index: libcxx/test/libcxx/strings/c.strings/version_cuchar.pass.cpp
===================================================================
--- libcxx/test/libcxx/strings/c.strings/version_cuchar.pass.cpp
+++ libcxx/test/libcxx/strings/c.strings/version_cuchar.pass.cpp
@@ -8,6 +8,10 @@
 //
 // XFAIL: *
 
+// Skip this test on windows. If built on top of the MSVC runtime, the
+// <cuchar> header actually does exist (although not provided by us).
+// UNSUPPORTED: windows
+
 // <cuchar>
 
 #include <cuchar>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99096.332363.patch
Type: text/x-patch
Size: 984 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210322/ef3e5854/attachment.bin>