[libcxx-commits] [PATCH] D99091: [locale][num_get] Improve Stage 2 of string to float conversion
Mikhail Maltsev via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Mar 22 10:33:54 PDT 2021
miyuki added inline comments.
Comment at: libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_float.pass.cpp:55
- const char str = "-123";
- std::ios_base::iostate err = ios.goodbit;
I think there is a reason behind having many similar-looking blocks: each assert() call is located on a separate line, so an assertion failure message will indicate which assertion failed. Factoring out all checks into a single function will make error messages much less informative.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits