[libcxx-commits] [PATCH] D99044: [libc++] Split out `<__functional_{ops, search}>` from `<functional>`. NFCI

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 22 08:40:08 PDT 2021


ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I would rather we use `__functional/XYZ.h` instead. Or if you convince me that `__functional_XYZ` is better instead, then we should make other headers consistent with that choice.

Also, just to clarify, you didn't modify any code at all, only moved it around, right? Your modifications to `__invoke` have been reverted from the patch. I checked, but I want to make double-sure that's your intent, since I'd push back on a change to the definition of the concept to use `__invoke`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99044/new/

https://reviews.llvm.org/D99044



More information about the libcxx-commits mailing list