[libcxx-commits] [PATCH] D99044: [libc++] Split out `<__functional_{ops, search}>` from `<functional>`

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added a comment.

This mostly LGTM. Thanks for the cleanup. It will be great to rely less on `<functional>`.

This change shouldn't have any observable effect so it might make sense to say "NFC" in the title.



================
Comment at: libcxx/include/__functional_search:10
+
+#ifndef _LIBCPP_FUNCTIONAL_SEARCH
+#define _LIBCPP_FUNCTIONAL_SEARCH
----------------
Does it make sense to combine these two headers?


================
Comment at: libcxx/include/concepts:394
 concept invocable = requires(_Fn&& __fn, _Args&&... __args) {
-  _VSTD::invoke(_VSTD::forward<_Fn>(__fn), _VSTD::forward<_Args>(__args)...); // not required to be equality preserving
+  _VSTD::__invoke(static_cast<_Fn&&>(__fn), static_cast<_Args&&>(__args)...); // not required to be equality preserving
 };
----------------
cjdb wrote:
> I'm against this change, per my reason in D99041.
You can keep using forward that comes from `utility/type_traits`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99044/new/

https://reviews.llvm.org/D99044