[libcxx-commits] [PATCH] D99043: [libc++] Move __libcpp_erase_if_container into <iterator>, and ADL-proof it

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Mar 21 14:30:27 PDT 2021


Quuxplusone created this revision.
Quuxplusone added reviewers: curdeius, libc++.
Quuxplusone added a project: libc++.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

The container headers don't need to include <functional> for any other reason (or at least, they wouldn't if we moved `less` and `equal_to` out of <functional>), so let's put `__libcpp_erase_if_container` somewhere that's common to the containers but outside of <functional>.

Also, calling `std::erase_if(c, pred)` should not trigger ADL.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99043

Files:
  libcxx/include/functional
  libcxx/include/iterator
  libcxx/include/map
  libcxx/include/set
  libcxx/include/unordered_map
  libcxx/include/unordered_set

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99043.332178.patch
Type: text/x-patch
Size: 5603 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210321/0dc73604/attachment.bin>


More information about the libcxx-commits mailing list