[libcxx-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

Nuno Lopes via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 19 16:23:04 PDT 2021

nlopes added a comment.

In D98179#2638801 <https://reviews.llvm.org/D98179#2638801>, @mehdi_amini wrote:

>> Can we revert to the previous behavior please? The current behavior is not user friendly. Thanks!
> To clarify: you care about the order in the final summary, not the actual execution order, right? (the goal of this patch is the latter, if it changes the former this is just a side-effect I believe)

I don't love that the default test order was changed. For our use case that isn't good, but I can just delete the `.lit_test_times.txt` file and get the old fixed order. (the reason why having a fixed order is good is because of timeouts. Also, slow tests often consume more memory in our setting, so it's not good to run all the slow tests at the same time).
So I'm just referring to the final summary, yes.

> How are you diffing? Copy-pasting the terminal output to a file? (I alway pipe these kind of list through `sort` before diffing them)

No, I'm running lit and dumping into a file. sorting is not as easy as piping through `sort`, as I'm running with -vv (required). Anyway, sorting the list on lit side should be 1 line for some that knows where that line goes :)

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list