[libcxx-commits] [libcxx] 3aa6a4c - [libcxx][Arm] Move buildbot flags into cmake files

[David Spickett via libcxx-commits]

Author: David Spickett
Date: 2021-03-19T16:45:09Z
New Revision: 3aa6a4cb39c4032983bbc0aaeda646ebdd3ebefa

URL: https://github.com/llvm/llvm-project/commit/3aa6a4cb39c4032983bbc0aaeda646ebdd3ebefa
DIFF: https://github.com/llvm/llvm-project/commit/3aa6a4cb39c4032983bbc0aaeda646ebdd3ebefa.diff

LOG: [libcxx][Arm] Move buildbot flags into cmake files

Reviewed By: #libc, Mordante, curdeius

Differential Revision: https://reviews.llvm.org/D98771

Added: 
    libcxx/cmake/caches/Armv7Arm.cmake
    libcxx/cmake/caches/Armv7Thumb-noexceptions.cmake
    libcxx/cmake/caches/Armv8Arm.cmake
    libcxx/cmake/caches/Armv8Thumb-noexceptions.cmake

Modified: 
    libcxx/utils/ci/run-buildbot

Removed: 
    libcxx/cmake/caches/Armv7.cmake
    libcxx/cmake/caches/Armv8.cmake


################################################################################
diff  --git a/libcxx/cmake/caches/Armv7.cmake b/libcxx/cmake/caches/Armv7Arm.cmake
similarity index 56%
rename from libcxx/cmake/caches/Armv7.cmake
rename to libcxx/cmake/caches/Armv7Arm.cmake
index 34b90083bd7d..8b2b54eba13c 100644
--- a/libcxx/cmake/caches/Armv7.cmake
+++ b/libcxx/cmake/caches/Armv7Arm.cmake
@@ -1,2 +1,4 @@
 set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "")
 set(LIBCXX_TARGET_TRIPLE "armv7-linux-gnueabihf" CACHE STRING "")
+set(CMAKE_CXX_FLAGS "-marm" CACHE STRING "")
+set(CMAKE_C_FLAGS "-marm" CACHE STRING "")

diff  --git a/libcxx/cmake/caches/Armv7Thumb-noexceptions.cmake b/libcxx/cmake/caches/Armv7Thumb-noexceptions.cmake
new file mode 100644
index 000000000000..67ec43b93f20
--- /dev/null
+++ b/libcxx/cmake/caches/Armv7Thumb-noexceptions.cmake
@@ -0,0 +1,6 @@
+set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "")
+set(LIBCXX_TARGET_TRIPLE "armv7-linux-gnueabihf" CACHE STRING "")
+set(CMAKE_CXX_FLAGS "-mthumb" CACHE STRING "")
+set(CMAKE_C_FLAGS "-mthumb" CACHE STRING "")
+set(LIBCXX_ENABLE_EXCEPTIONS OFF CACHE BOOL "")
+set(LIBCXXABI_ENABLE_EXCEPTIONS OFF CACHE BOOL "")

diff  --git a/libcxx/cmake/caches/Armv8.cmake b/libcxx/cmake/caches/Armv8Arm.cmake
similarity index 56%
rename from libcxx/cmake/caches/Armv8.cmake
rename to libcxx/cmake/caches/Armv8Arm.cmake
index 85da66cbea54..55dfa908b3d0 100644
--- a/libcxx/cmake/caches/Armv8.cmake
+++ b/libcxx/cmake/caches/Armv8Arm.cmake
@@ -1,2 +1,4 @@
 set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "")
 set(LIBCXX_TARGET_TRIPLE "armv8-linux-gnueabihf" CACHE STRING "")
+set(CMAKE_CXX_FLAGS "-marm" CACHE STRING "")
+set(CMAKE_C_FLAGS "-marm" CACHE STRING "")

diff  --git a/libcxx/cmake/caches/Armv8Thumb-noexceptions.cmake b/libcxx/cmake/caches/Armv8Thumb-noexceptions.cmake
new file mode 100644
index 000000000000..fb1d10efaddc
--- /dev/null
+++ b/libcxx/cmake/caches/Armv8Thumb-noexceptions.cmake
@@ -0,0 +1,6 @@
+set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "")
+set(LIBCXX_TARGET_TRIPLE "armv8-linux-gnueabihf" CACHE STRING "")
+set(CMAKE_CXX_FLAGS "-mthumb" CACHE STRING "")
+set(CMAKE_C_FLAGS "-mthumb" CACHE STRING "")
+set(LIBCXX_ENABLE_EXCEPTIONS OFF CACHE BOOL "")
+set(LIBCXXABI_ENABLE_EXCEPTIONS OFF CACHE BOOL "")

diff  --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot
index f76a669f9f1d..04f6cf3fc375 100755
--- a/libcxx/utils/ci/run-buildbot
+++ b/libcxx/utils/ci/run-buildbot
@@ -402,35 +402,23 @@ aarch64-noexceptions)
 # Aka Armv8 32 bit
 armv8)
     clean
-    generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv8.cmake" \
-    -DCMAKE_CXX_FLAGS="-marm" \
-    -DCMAKE_C_FLAGS="-marm"
+    generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv8Arm.cmake"
     check-cxx-cxxabi
 ;;
 armv8-noexceptions)
     clean
-    generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv8.cmake" \
-    -DCMAKE_CXX_FLAGS="-mthumb" \
-    -DCMAKE_C_FLAGS="-mthumb" \
-    -DLIBCXX_ENABLE_EXCEPTIONS=OFF \
-    -DLIBCXXABI_ENABLE_EXCEPTIONS=OFF
+    generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv8Thumb-noexceptions.cmake"
     check-cxx-cxxabi
 ;;
 # Armv7 32 bit. One building Arm only one Thumb only code.
 armv7)
     clean
-    generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv7.cmake" \
-    -DCMAKE_CXX_FLAGS="-marm" \
-    -DCMAKE_C_FLAGS="-marm"
+    generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv7Arm.cmake"
     check-cxx-cxxabi
 ;;
 armv7-noexceptions)
     clean
-    generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv7.cmake" \
-    -DCMAKE_CXX_FLAGS="-mthumb" \
-    -DCMAKE_C_FLAGS="-mthumb" \
-    -DLIBCXX_ENABLE_EXCEPTIONS=OFF \
-    -DLIBCXXABI_ENABLE_EXCEPTIONS=OFF
+    generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv7Thumb-noexceptions.cmake"
     check-cxx-cxxabi
 ;;
 *)