[libcxx-commits] [PATCH] D98643: [libcxx] [test] Fix weakly_canonical for windows

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 19 07:03:05 PDT 2021


mstorsjo added inline comments.


================
Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.weakly_canonical/weakly_canonical.pass.cpp:73
     fs::path p(TC.input);
+    fs::path expect(TC.expect);
+    expect.make_preferred();
----------------
curdeius wrote:
> If you change `p`, then change`expect` as well.
Sure, can do that. Why is such a change desired/why does it matter btw?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98643/new/

https://reviews.llvm.org/D98643



More information about the libcxx-commits mailing list