[libcxx-commits] [PATCH] D96477: [libcxx] adds remaining callable concepts

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added a comment.

Can we please change the `.compile.cpp` to just `.pass.cpp`. There's very little to no cost to actually run the test, and doing so seems safer to me.
It avoids allowing runtime tests to be mistakenly added to these files without anybody noticing.



================
Comment at: libcxx/test/std/concepts/callable/strictweakorder.compile.pass.cpp:82
+      /// NotStrictWeakOrder(Predicate::L2rSorted(), 0, 0.0);
+      /// NotStrictWeakOrder(Predicate::NotAPredicate(), 0, 0);
+      /// ModelsStrictWeakOrder(Predicate::LambdaPredicate, 0, 1.0);
----------------
Commented out tests?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96477/new/

https://reviews.llvm.org/D96477