[libcxx-commits] [PATCH] D98151: [libcxx] adds std::identity to <functional>

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added inline comments.


================
Comment at: libcxx/test/std/utilities/function.objects/func.identity/identity.pass.cpp:23
+constexpr auto id = std::identity();
+static_assert(requires { typename std::identity::is_transparent; });
+
----------------
Is the type required to be `void`? If so, add a test.


================
Comment at: libcxx/test/std/utilities/function.objects/func.identity/identity.pass.cpp:111
+
+  [[noexcept]] constexpr bool operator==(S2 const&) const noexcept = default;
+};
----------------
Do we the defaulted comparison operator here? I would rather not depend on yet another new language feature that we don't need too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98151/new/

https://reviews.llvm.org/D98151