[libcxx-commits] [PATCH] D98771: [libcxx][Arm] Move buildbot flags into cmake files

[David Spickett via Phabricator via libcxx-commits]

DavidSpickett added inline comments.


================
Comment at: libcxx/cmake/caches/Armv7Arm.cmake:2
 set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "")
 set(LIBCXX_TARGET_TRIPLE "armv7-linux-gnueabihf" CACHE STRING "")
+set(CMAKE_CXX_FLAGS "-marm" CACHE STRING "")
----------------
DavidSpickett wrote:
> Just FYI, you might have seen triples like `thumv7-linux-gnueabihf` but these only apply to cc1. You can give those to clang but it'll convert them to `armv7-linux-gnueabihf`. That's why we need the extra `-marm/-mthumb` flags.
(that should be `thumbv7-linux-gnueabihf`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98771/new/

https://reviews.llvm.org/D98771