[libcxx-commits] [PATCH] D98019: [libcxx] Move Linaro 32 bit armv bots to buildkite

[David Spickett via Phabricator via libcxx-commits]

DavidSpickett marked an inline comment as done.
DavidSpickett added inline comments.


================
Comment at: libcxx/utils/ci/run-buildbot:406
+    generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv8.cmake" \
+    -DCMAKE_CXX_FLAGS="-marm" \
+    -DCMAKE_C_FLAGS="-marm"
----------------
ldionne wrote:
> Why do we need to set these flags here? Ideally, everything would be handled by the CMake cache. Same below.
We don't, for some reason I was trying to balance number of cache files and options here.

Move the flags into cache files: https://reviews.llvm.org/D98771


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98019/new/

https://reviews.llvm.org/D98019