[libcxx-commits] [PATCH] D98642: [libcxx] [test] Account for differences in a trailing slash in weakly_canonical

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 16 12:31:55 PDT 2021

Mordante added a comment.

In D98642#2628690 <https://reviews.llvm.org/D98642#2628690>, @mstorsjo wrote:

> In D98642#2628622 <https://reviews.llvm.org/D98642#2628622>, @curdeius wrote:
>> Wouldn't it be judicious to try to fix the underlying problem (as noted in the fixme comment)?
>> It seems to be of a similar nature as http://wg21.link/LWG3096, i.e. the fact whether (a part of) the path exists or not shouldn't matter.
>> WDYT?
> Well, maybe, but I'm afraid that might open a potentially big can of worms... Also, for reference, both MS STL and libstdc++ seem to have the same quirk regarding weakly_canonical sometimes returning paths with a trailing slash and sometimes not.

In that case I think it would be better to remove the FIXME and document the quirk including the fact that this matches the behaviour of MS STL and libstdc++.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list