[libcxx-commits] [PATCH] D98097: [libc++] "Merged wording" for D98077 and D96986

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: libcxx/src/filesystem/filesystem_common.h:88
+format_string(const char* msg, ...) {
+  std::string ret;
+  va_list ap;
----------------
Quuxplusone wrote:
> Mordante wrote:
> > For consistency can you remove `std::`?
> Done (and also on line 71). This file does contain some `std::`s, on `declval` and `array`, but not on `string`. (Personally I wish it would put `std::` on everything, just like user code should. We're not doing anything "special" in this file that //requires// us to deviate from the usual good practice; the current use of unqualified `string` is just inessential mental noise IMO.)
I don't mind adding `std::`. Just as long as the code is consistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98097/new/

https://reviews.llvm.org/D98097