[libcxx-commits] [PATCH] D98720: [libc++] Consistency in _LIBCPP_CLANG_VER tests in <type_traits>

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 16 09:55:08 PDT 2021


Quuxplusone added inline comments.


================
Comment at: libcxx/include/type_traits:1465
 
-#else // __has_keyword(__is_unsigned) && _LIBCPP_CLANG_VER >= 1300
+#else // __has_keyword(__is_unsigned)
 
----------------
FWIW: Reverted the addition of `&& _LIBCPP_CLANG_VER >= 1300` here, for consistency with how we do it in the other places whose `#if`s I'm changing. The compiler-version-specific epicycles don't show up in the `#else` or `#endif` comments there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98720/new/

https://reviews.llvm.org/D98720



More information about the libcxx-commits mailing list